Support non-numeric characters in VersionRequirement (e.g. version = "r09")
---------------------------------------------------------------------------
Key: BUILDR-615
URL: https://issues.apache.org/jira/browse/BUILDR-615
Project: Buildr
Issue Type: Bug
Components: Dependency management
Affects Versions: 1.4.6
Reporter: Alex Boisvert
Assignee: Alex Boisvert
Priority: Minor
>From this thread: http://buildr.markmail.org/thread/kkpbbzmxyb4ojgbs
Consider the following namespace code:
REQUIRES = ArtifactNamespace.for(self) do |ns|
ns.guava! "com.google.guava:guava:jar:r09"
ns.javassist! "javassist:javassist:jar:3.8.0.GA"
ns.reflections! "org.reflections:reflections:jar:0.9.5-RC1"
end
The guava spec here causes the following error to be raised
Invalid version: "r09"
This is a result of VersionRequirement.version? which checks the version
string against the regex
/^\s*\d[#{VER_CHARS}]*\s*$/
This regex is checked here
raise "Invalid version: #{version.inspect}" unless
self.class.version?(version)
So it seems that maybe this regex could be expanded to include versions
like 'r09'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
