Update checkstyle addon to support downloading checkstyle checks as an artifact.
Project: http://git-wip-us.apache.org/repos/asf/buildr/repo Commit: http://git-wip-us.apache.org/repos/asf/buildr/commit/888c345e Tree: http://git-wip-us.apache.org/repos/asf/buildr/tree/888c345e Diff: http://git-wip-us.apache.org/repos/asf/buildr/diff/888c345e Branch: refs/heads/master Commit: 888c345ed8338e90e48bdd8954c79e1695012956 Parents: c4bd791 Author: Peter Donald <[email protected]> Authored: Mon Sep 22 19:15:16 2014 +1000 Committer: Peter Donald <[email protected]> Committed: Mon Sep 22 19:15:16 2014 +1000 ---------------------------------------------------------------------- CHANGELOG | 2 ++ addon/buildr/checkstyle.rb | 24 +++++++++++++++++++++++- 2 files changed, 25 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/buildr/blob/888c345e/CHANGELOG ---------------------------------------------------------------------- diff --git a/CHANGELOG b/CHANGELOG index bfac3fb..efe4f26 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,4 +1,6 @@ 1.4.21 (Pending) +* Added: Update checkstyle addon to support downloading checkstyle checks + as an artifact. * Added: Update checkstyle addon to supply checkstyle.config.dir property. * Added: Update pmd addon to support downloading rule files as an artifact. * Change: Update pmd addon to use pmd version 5.1.3. http://git-wip-us.apache.org/repos/asf/buildr/blob/888c345e/addon/buildr/checkstyle.rb ---------------------------------------------------------------------- diff --git a/addon/buildr/checkstyle.rb b/addon/buildr/checkstyle.rb index 2215c50..854f7f3 100644 --- a/addon/buildr/checkstyle.rb +++ b/addon/buildr/checkstyle.rb @@ -85,8 +85,30 @@ module Buildr attr_writer :configuration_file + def configuration_file=(configuration_file) + raise 'Configuration artifact already specified' if @configuration_artifact + @configuration_file = configuration_file + end + def configuration_file - @configuration_file || "#{self.config_directory}/checks.xml" + if @configuration_file + return @configuration_file + elsif @configuration_artifact.nil? + "#{self.config_directory}/checks.xml" + else + a = Buildr.artifact(@configuration_artifact) + a.invoke + a.to_s + end + end + + def configuration_artifact=(configuration_artifact) + raise 'Configuration file already specified' if @configuration_file + @configuration_artifact = configuration_artifact + end + + def configuration_artifact + @configuration_artifact end attr_writer :fail_on_error
