Avoid messing around with outputfile and assume checkstyle command line application behaves sensibly
Project: http://git-wip-us.apache.org/repos/asf/buildr/repo Commit: http://git-wip-us.apache.org/repos/asf/buildr/commit/8b77fa2d Tree: http://git-wip-us.apache.org/repos/asf/buildr/tree/8b77fa2d Diff: http://git-wip-us.apache.org/repos/asf/buildr/diff/8b77fa2d Branch: refs/heads/master Commit: 8b77fa2d9aa35c75eeddd4f984124be9e2b40eb5 Parents: ccf2521 Author: Peter Donald <[email protected]> Authored: Fri Nov 27 18:07:11 2015 +1100 Committer: Peter Donald <[email protected]> Committed: Fri Nov 27 18:07:11 2015 +1100 ---------------------------------------------------------------------- addon/buildr/checkstyle.rb | 2 -- 1 file changed, 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/buildr/blob/8b77fa2d/addon/buildr/checkstyle.rb ---------------------------------------------------------------------- diff --git a/addon/buildr/checkstyle.rb b/addon/buildr/checkstyle.rb index 011b0a7..774ba9d 100644 --- a/addon/buildr/checkstyle.rb +++ b/addon/buildr/checkstyle.rb @@ -53,10 +53,8 @@ module Buildr args += source_paths.select { |p| File.exist?(p) } begin - touch output_file Java::Commands.java 'com.puppycrawl.tools.checkstyle.Main', *(args + [{:classpath => cp, :properties => options[:properties], :java_args => options[:java_args]}]) rescue Exception => e - rm_f output_file raise e if options[:fail_on_error] end end
