[ 
https://issues.apache.org/jira/browse/BUILDR-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antoine Toulme closed BUILDR-231.
---------------------------------
    Resolution: Auto Closed

Closing for inactivity.

> ArchiveTask#needed? does not detect sources properly
> ----------------------------------------------------
>
>                 Key: BUILDR-231
>                 URL: https://issues.apache.org/jira/browse/BUILDR-231
>             Project: Buildr
>          Issue Type: Bug
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.5
>
>
> #needed? iterates over @paths, getting 'sources' from each and then checking 
> each source directly for existence and timestamp.
> however, the packaging itself is done by iterating the actions of each path. 
> some actions descend into the source if it is a directory and package 
> individual files (see include_as)
> scenario:
> directory 'foo' contains file 'baz'. 
> in the project definition i  use 'package(:jar).include('foo', :as => 'bar')'
> call 'package' task on the project => package is created with 'bar/baz'
> modify 'baz'
> call 'package' task on the project => nothing is done. (the reason is that 
> needed? will check the timestamp of 'foo' not 'baz')
> note that this also means that excluded sources may trigger tasks 
> unnecessarily (since exclusion is only checked in the action).
> suggestion: the action associated with each source should use the paths 
> returned by the source block as is, without descending. the source block 
> should do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to