This is an automated email from the ASF dual-hosted git repository. not-in-ldap pushed a commit to branch tristan/multi-location-overlaps in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit bd23f982be498aae9389ddfb01c3d01c53f14ff0 Author: Tristan van Berkom <[email protected]> AuthorDate: Thu Sep 10 21:35:25 2020 +0900 tests/elements/filter/basic/element_plugins/dynamic.py: Stage in Element.stage() This test element was also staging artifacts in Element.assemble(), which is now illegal. --- tests/elements/filter/basic/element_plugins/dynamic.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/elements/filter/basic/element_plugins/dynamic.py b/tests/elements/filter/basic/element_plugins/dynamic.py index 16a6008..401c6b1 100644 --- a/tests/elements/filter/basic/element_plugins/dynamic.py +++ b/tests/elements/filter/basic/element_plugins/dynamic.py @@ -20,13 +20,10 @@ class DynamicElement(Element): pass def stage(self, sandbox): - pass - - def assemble(self, sandbox): with self.timed_activity("Staging artifact", silent_nested=True): - for dep in self.dependencies(): - dep.stage_artifact(sandbox) + self.stage_dependency_artifacts(sandbox) + def assemble(self, sandbox): bstdata = self.get_public_data("bst") bstdata["split-rules"] = self.split_rules self.set_public_data("bst", bstdata)
