This is an automated email from the ASF dual-hosted git repository. tvb pushed a commit to branch phil/ui-split-refactor in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit b9bcb00b1719396c40b75b98d9c50de83ddbf42a Author: Tom Pollard <[email protected]> AuthorDate: Wed Jul 31 16:31:47 2019 +0100 _message.py: Use element_name & element_key instead of unique_id Adding the element full name and display key into all element related messages removes the need to look up the plugintable via a plugin unique_id just to retrieve the same values for logging and widget frontend display. Relying on plugintable state is also incompatible if the frontend will be running in a different process, as it will exist in multiple states. An Element instance is passed exclusively if handling interactive failures. The element full name is now displayed instead of the unique_id, such as in the debugging widget. It is also displayed in place of 'name' (i.e including any junction prepend) to be more informative. --- src/buildstream/_frontend/app.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/buildstream/_frontend/app.py b/src/buildstream/_frontend/app.py index e1b1d8d..76e3bc7 100644 --- a/src/buildstream/_frontend/app.py +++ b/src/buildstream/_frontend/app.py @@ -586,6 +586,7 @@ class App(): "unable to retrieve failure message for element {}\n\n\n\n\n" .format(full_name), err=True) else: + # Note element will be given if in interactive failure mode self._handle_failure(element, queue, failure) else:
