This is an automated email from the ASF dual-hosted git repository. tvb pushed a commit to branch gokcen/just_set_for_visited in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 82f13baea757be4738efcdae74cf33923df8fc3a Author: Gökçen Nurlu <[email protected]> AuthorDate: Mon Dec 23 15:22:41 2019 +0000 hmmm sets --- src/buildstream/_pipeline.py | 3 ++- src/buildstream/element.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/buildstream/_pipeline.py b/src/buildstream/_pipeline.py index aee0c55..7c480ab 100644 --- a/src/buildstream/_pipeline.py +++ b/src/buildstream/_pipeline.py @@ -186,7 +186,8 @@ class Pipeline: def dependencies(self, targets, scope, *, recurse=True): # Keep track of 'visited' in this scope, so that all targets # share the same context. - visited = (BitMap(), BitMap()) + # visited = (BitMap(), BitMap()) + visited = set(), set() for target in targets: for element in target.dependencies(scope, recurse=recurse, visited=visited): diff --git a/src/buildstream/element.py b/src/buildstream/element.py index ee6b90c..6f484e6 100644 --- a/src/buildstream/element.py +++ b/src/buildstream/element.py @@ -499,7 +499,8 @@ class Element(Plugin): if visited is None: # Visited is of the form (Visited for Scope.BUILD, Visited for Scope.RUN) - visited = (BitMap(), BitMap()) + # visited = (BitMap(), BitMap()) + visited = set(), set() else: # We have already a visited set passed. we might be able to short-circuit if scope in (Scope.BUILD, Scope.ALL) and self._unique_id in visited[0]:
