gtristan commented on a change in pull request #1438:
URL: https://github.com/apache/buildstream/pull/1438#discussion_r577391373
##########
File path: src/buildstream/_frontend/app.py
##########
@@ -711,7 +711,7 @@ def _handle_failure(self, element, task, failure):
_Scope.BUILD,
self.shell_prompt,
isolate=True,
- usebuildtree="always",
+ usebuildtree=True,
Review comment:
This is just a side effect of changing the various `Stream()` APIs
(using the new type annotations for the changed APIs) and reviewing all of the
call sites for these changed `Stream()` APIs.
There is no such thing as `"always"` as an answer to the question *"Shall I
use a build tree for this shell"*, this does not technically fix any bug
because `"always"` is a truthy value, but the signature takes a `bool`, so we
now give it a `bool`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
