juergbi commented on a change in pull request #1450:
URL: https://github.com/apache/buildstream/pull/1450#discussion_r587404762
##########
File path: src/buildstream/_artifactelement.py
##########
@@ -131,9 +131,9 @@ def clear_artifact_name_cache(cls):
# Once we've finished pulling an artifact, we assume the
# state of the pulled artifact.
#
- def _pull_done(self):
- super()._pull_done()
+ def _load_artifact_done(self):
Review comment:
Using the `_load_artifact()` code path for artifact element early
loading seems sensible. I've pushed a separate commit for this.
In `Stream.query_cache()` I've added an explicit no-op case if the artifact
has already been loaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
