gtristan commented on issue #819: URL: https://github.com/apache/buildstream/issues/819#issuecomment-938397402
The landscape has changed a lot since this was originally filed. As of commit 868ff50c721164a9c24e076e163bed02145c4624 (a part of #915), there is no longer any option for fetching sources for checkout. Looking back at the [original thread](https://mail.gnome.org/archives/buildstream-list/2018-December/msg00000.html), in @sstriker's [reply]( https://mail.gnome.org/archives/buildstream-list/2018-December/msg00083.html) I'm reading: > "the commands should do whatever is needed, _but not more_, to perform the specified action, except where especially destructive or costly" And I think we're doing this by trying to fetch the sources when we don't already have them, not optionally. This does however point to an inconsistency remaining in `bst artifact checkout`, which explicitly requires a `--pull` option to be specified if we are to pull the artifact, I think we should remove that option in order to bring the two commands in line. An interesting side note to this, is that by now we also have `--source-remote` / `--ignore-project-source-remotes` and `--artifact-remote` / `--ignore-project-artifact-remotes` consistently in commands which use remotes - for `bst artifact checkout` this will effectively allow one to avoid pulling artifacts if that is indeed desired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
