gtristan commented on a change in pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#discussion_r740898037



##########
File path: tests/integration/project/elements/sandbox-bwrap/test-dev-shm.bst
##########
@@ -0,0 +1,15 @@
+kind: manual

Review comment:
       Update, after discussing this on slack we will update this patch to also 
add yaml configuration for this for `BuildElement` and `ScriptElement` classes 
so that projects can easily enable creation of `/dev/shm`, since this is more 
urgent with glibc 2.34 as highlighted in #1525 
   

##########
File path: tests/integration/project/elements/sandbox-bwrap/test-dev-shm.bst
##########
@@ -0,0 +1,15 @@
+kind: manual

Review comment:
       Update: after discussing this on slack we will update this patch to also 
add yaml configuration for this for `BuildElement` and `ScriptElement` classes 
so that projects can easily enable creation of `/dev/shm`, since this is more 
urgent with glibc 2.34 as highlighted in #1525 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to