gtristan commented on code in PR #1645:
URL: https://github.com/apache/buildstream/pull/1645#discussion_r867324111
##########
src/buildstream/_elementsourcescache.py:
##########
@@ -195,7 +197,7 @@ def _get_source(self, ref):
source_proto.ParseFromString(f.read())
return source_proto
except FileNotFoundError as e:
- raise SourceCacheError("Attempted to access unavailable source:
{}".format(e)) from e
+ raise SourceCacheError("Attempted to access unavailable source:
{}".format(e), temporary=True) from e
Review Comment:
If I understand correctly, here we are about to push sources (this is called
from `self._push_source()`) and we call `_get_source()` to get the proto from
local CAS.
I suppose this error could occur if for some reason the local source has
been purged/expired from local CAS before pushing.
I don't think this error can possibly recover with retries, so `temporary`
is probably wrong in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
