nanonyme commented on code in PR #25:
URL: https://github.com/apache/buildstream-plugins/pull/25#discussion_r944622226
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,6 +94,8 @@ config:
- |
%{autogen}
- |
+ mkdir -p "%{build-dir}"
+ cd "%{build-dir}"
%{configure}
Review Comment:
These aren't actually concatenated into one shell script but run in
subshells. (as was educated to me by @gtristan) It's unnecessary to restore
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
