gtristan commented on PR #1714:
URL: https://github.com/apache/buildstream/pull/1714#issuecomment-1214049069
@ssssam overall it looks good to me, I have some concerns.
* This adds a lot of complexity to `setup.py`, I wonder if we need to worry
about upstream python deprecating `setup.py` and if so, whether their
alternatives will provide the flexibility we now require.
* This will run CI on the wheels we upload only at tag/release time, which
presents some workflow complexity
* Currently we test everything that is required when merging a commit to
master, so we already know that CI will pass on a tag
* I don't think we want to build wheels and run CI on wheels for every
merge to master, CI is already quite lengthy
Maybe if building wheels and running the single test is not too onerous, we
should still run this in normal CI (without publishing) in addition to when we
tag a release ?
Otherwise, perhaps we could have a special tag semantic especially for the
purpose of running this CI in advance of tagging ? like `1.95.2-test1` could be
a test run of the release without actually publishing a release ? Just a
thought, open to any other ideas of how we could solve this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
