cs-shadow commented on code in PR #1714: URL: https://github.com/apache/buildstream/pull/1714#discussion_r947285404
########## requirements/requirements.in: ########## @@ -1,6 +1,7 @@ Click >= 7.0 grpcio Jinja2 >= 2.10 +packaging Review Comment: oh I missed one thing, I don't think this is the right place for this requirement as we don't need it at runtime. Since it's only needed at build time, it should only be in the `requires` section of `pyproject.toml`. And it seems like you've already added it there so I believe you can just remove this line (this should also have an agreeable side-effect of removing all the dependency version changes from the diff) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
