nanonyme commented on code in PR #1832:
URL: https://github.com/apache/buildstream/pull/1832#discussion_r1264522528
##########
src/buildstream/downloadablefilesource.py:
##########
@@ -235,8 +235,12 @@ def _ensure_mirror(self, activity_name: str):
return self.ref
# Make sure url-specific mirror dir exists.
- if not os.path.isdir(self._mirror_dir):
- os.makedirs(self._mirror_dir)
+ try:
+ os.makedirs(self._mirror_dir, exist_ok=True)
Review Comment:
Is this basically a "plugin completely broke backwards-compat" case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
