gtristan commented on issue #54:
URL: 
https://github.com/apache/buildstream-plugins/issues/54#issuecomment-1751913538

   This is an interesting class of bug.
   
   Obviously we would prefer meson to behave in a `--wrap-mode=nodownload` 
manner in order to produce a more human readable failure, as this would 
communicate the problem more clearly to project authors.
   
   However we cannot fix this without breaking cache keys.
   
   The policy for changing cache keys is that it must be _"buy in"_ so that 
cache keys don't change without explicit plugin configuration selected, but in 
this case it is annoying to have to buy into a behavior that should really be 
default.
   
   What's more, I'm not sure that the meson plugin parsing additional 
configuration can modify `%{meson-args}` in an optional way without implicitly 
breaking cache keys (i.e. there would have to be some `if` statement inserted 
into the configure commands).
   
   The only non-breaking way I can think of off the top of my head right now, 
is for downstream users to explicitly add `--wrap-mode=nodownload` to 
`meson-global` in the project.conf variables.
   
   If meson wrap mode could be controlled with environment variables, we might 
be able to use that in conjunction with `environment-nocache` in order to set 
this up without affecting cache keys (although I haven't given this enough 
thought to be 100% confident that this would be correct).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to