wsalmonct commented on PR #58: URL: https://github.com/apache/buildstream-plugins/pull/58#issuecomment-1777223078
Does this silently ignore `image` and `registry-url` if `url` is present? It raises a error if nether are present. but should it not also raise a error if both are? The condition of both `image` and `url` does not cause a error as such but it does cause unexpected behaviour. usually if you provide a key that is not used then bst causes a error (node.validate_keys) so i think the extra error would follow the existing patten? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
