This is an automated email from the ASF dual-hosted git repository. akitouni pushed a commit to branch abderrahim/mark-url-check in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 146b424b14aff232c36ed03384f936221aa50102 Author: Abderrahim Kitouni <[email protected]> AuthorDate: Tue Mar 5 09:45:27 2024 +0100 source: disable check for URL marking at configure time This check is triggered by plugins that have URLs (or URL fragments) as part of their ref, such as cargo. These plugins currently resort to only translating part of the URL and appending the rest later. Ultimately, this check should be investigated and probably only relaxed rather than dropped entirely. --- src/buildstream/source.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/buildstream/source.py b/src/buildstream/source.py index 0278c5a32..fac63e340 100644 --- a/src/buildstream/source.py +++ b/src/buildstream/source.py @@ -782,9 +782,7 @@ class Source(Plugin): # the case for git submodules which might be automatically # discovered. # - assert url in self.__marked_urls or not _extract_alias( - url - ), "URL was not seen at configure time: {}".format(url) + pass alias = _extract_alias(url)
