gtristan commented on code in PR #1898:
URL: https://github.com/apache/buildstream/pull/1898#discussion_r1526215919
##########
src/buildstream/types.py:
##########
@@ -274,6 +274,10 @@ class _SourceUriPolicy(FastEnum):
# configuration has not provided a mirror
USER = "user"
+ # Use only URIs defined in the toplevel project (the project on which
+ # BuildStream was invoked with as opposed to a junctioned subproject.
+ TOPLEVEL = "toplevel"
Review Comment:
I think we can avoid adding a policy here, which requires user configuration
to decide which sources should be used when fetching and tracking.
Instead, I think that the project itself should be in charge of deciding if
it is providing mirrors for it's subprojects, and this behavior is then used
unconditionally for the `SourceUriPolicy.MIRRORS` portion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
