gtristan commented on PR #1906: URL: https://github.com/apache/buildstream/pull/1906#issuecomment-2028204286
In general I think this patch is probably right, I'm mostly confused by the added project.conf `junctions` configuration `disallow_subproject_uris`. I think my previous comments can be discarded, but I'd like this patch to: * Come with the `doc/source/format_project.rst` changes describing what exactly this new configuration does * Ideally come with a test validating that this does what it is intended to do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
