gtristan commented on code in PR #1918:
URL: https://github.com/apache/buildstream/pull/1918#discussion_r1599848025
##########
tests/frontend/mirror.py:
##########
@@ -895,9 +895,29 @@ def test_source_mirror_plugin(cli, tmpdir):
@pytest.mark.parametrize("unaliased_sources", [True, False])
@pytest.mark.parametrize("disallow_subproject_uris", [True, False])
@pytest.mark.parametrize("fetch_source", ["aliases", "mirrors"])
[email protected]("alias_override", [["foo"], ["foo", "bar"], "global",
"invalid"])
[email protected](
Review Comment:
Can we have a comment around here explaining why this level of parameterized
testing is needed, and what defects we are specifically protecting against ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
