This is an automated email from the ASF dual-hosted git repository.

akitouni pushed a commit to branch abderrahim/script-logging
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit a38ba54fd8e765bb800dba29366519214d060cd0
Author: Abderrahim Kitouni <[email protected]>
AuthorDate: Fri Aug 2 11:28:59 2024 +0100

    scriptelement: Fix time logging of integration commands
    
    sandbox.batch() needs to happen within the timed_activity for it to count
    the time it needs to run the command
---
 src/buildstream/scriptelement.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/buildstream/scriptelement.py b/src/buildstream/scriptelement.py
index 4b798ad66..a24ddcee8 100644
--- a/src/buildstream/scriptelement.py
+++ b/src/buildstream/scriptelement.py
@@ -233,7 +233,7 @@ class ScriptElement(Element):
             root_list = self.__layout.get("/", None)
             if root_list:
                 element_list = [element for element, _ in root_list]
-                with sandbox.batch(), self.timed_activity("Integrating 
sandbox", silent_nested=True):
+                with self.timed_activity("Integrating sandbox", 
silent_nested=True), sandbox.batch():
                     for dep in self.dependencies(element_list):
                         dep.integrate(sandbox)
 

Reply via email to