This is an automated email from the ASF dual-hosted git repository. akitouni pushed a commit to branch abderrahim/re-port in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit e4aa7d39ed4572289a94b2f41945398dc15292bc Author: Abderrahim Kitouni <[email protected]> AuthorDate: Fri Aug 2 11:31:53 2024 +0100 _remotespec: allow using the default port for remote execution endpoints --- src/buildstream/_remotespec.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/buildstream/_remotespec.py b/src/buildstream/_remotespec.py index b90cd6c1c..7414e0f1f 100644 --- a/src/buildstream/_remotespec.py +++ b/src/buildstream/_remotespec.py @@ -202,16 +202,6 @@ class RemoteSpec: def open_channel(self) -> Channel: url = urlparse(self.url) - # Assert port number for RE endpoints - # - if self.remote_type == RemoteType.ENDPOINT and not url.port: - message = ( - "Remote execution endpoints must specify the port number, for example: http://buildservice:50051."; - ) - if self._spec_node: - message = "{}: {}".format(self._spec_node.get_provenance(), message) - raise RemoteError(message) - if url.scheme == "http": channel = grpc.insecure_channel("{}:{}".format(url.hostname, url.port or 80)) elif url.scheme == "https":
