juergbi commented on code in PR #1962:
URL: https://github.com/apache/buildstream/pull/1962#discussion_r1798946870
##########
src/buildstream/sandbox/_sandboxremote.py:
##########
@@ -294,12 +294,20 @@ def _execute_action(self, action, flags):
# Fetch outputs
for output_directory in action_result.output_directories:
+ # Now do a pull to ensure we have the full directory structure.
+ # We first try the root_directory_digest we requested, then fall
back to tree_digest
+
+ root_directory_digest = output_directory.root_directory_digest
+ if root_directory_digest and root_directory_digest.hash:
+ cascache._fetch_directory(casremote, root_directory_digest)
Review Comment:
Nit, `_fetch_directory()` should be marked as public (internal) by removing
the leading underscore as we're calling it from outside `cascache.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
