juergbi commented on code in PR #1979:
URL: https://github.com/apache/buildstream/pull/1979#discussion_r1910505690


##########
contrib/bst-graph:
##########
@@ -55,6 +56,10 @@ def parse_args():
     return parser.parse_args()
 
 
+def escape(s):
+    return urllib.parse.quote_plus(s.encode())

Review Comment:
   Is this the right function to use for escaping? Might 
[graphviz.escape()](https://graphviz.readthedocs.io/en/stable/api.html#graphviz.escape)
 be a better fit (I haven't tested it)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to