gtristan commented on PR #2000: URL: https://github.com/apache/buildstream/pull/2000#issuecomment-2717309290
I don't like splitting hairs in this documentation, as it is a bit redundant. The issue is what is considered *"build dependencies"* for an element. Rather, it may be good to provide a link in this docstring to https://docs.buildstream.build/master/format_declaring.html#dependency-types See the note where we clarify this (which is a much more satisfying explanation IMO): > It is assumed that a dependency which is required for building an element must run while building the depending element. This means that build depending on a given element implies that that element’s runtime dependencies will also be staged for the purpose of building. Perhaps we can reword your patch in a way that links to this section and clarifies that the dependencies are *build dependencies* in the context of a toplevel element which invoked this function ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
