gtristan commented on PR #1997: URL: https://github.com/apache/buildstream/pull/1997#issuecomment-2820635130
[...] > > Do you think there is any reason to have 2 different strings (one for the medium and one for the version) ? Or would it be sufficient to have a single string to define how a given `SourceInfo` instance behaves ? I came to the following conclusions: * I liked that we had strong types, it helps how things are documented * I liked that we had this separation of "where it comes from" and "what the version means", as stated before on this issue, this reduces the need for a lot of redundant enum values * We do still have a need for third party plugin developers to use freeform strings, as discussed last week I've updated the branch to use `Union[SourceVersionType, str]` and `Union[SourceInfoMedium, str]` types and reverted to the original implementation with this change, this seems to be a happy compromise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
