gtristan commented on code in PR #2005:
URL: https://github.com/apache/buildstream/pull/2005#discussion_r2114151169
##########
tests/integration/cachedfail.py:
##########
@@ -514,3 +425,61 @@ def generate_target():
# Assert that it's no longer cached, and returns to a buildable state
assert cli.get_element_state(project, "target.bst") == "buildable"
+
+
+# Test that we do not keep scheduling builds after one build fails
+# with `--builders 1` and `--on-error quit`.
+#
+# Note that this depends on staging order (which is stable and a part of cache
key calculation),
Review Comment:
Ok, I've taken your approach of just launching two failing builds, and also
verified that the new test also fails with your patch reverted... this one
should be good !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
