abderrahim commented on code in PR #2018:
URL: https://github.com/apache/buildstream/pull/2018#discussion_r2120652569
##########
src/buildstream/source.py:
##########
@@ -1078,11 +1063,8 @@ def collect_source_info(self) -> Iterable[SourceInfo]:
SourceInfo objects created by implementors should be created with
:func:`Source.create_source_info()
<buildstream.source.Source.create_source_info>`.
- Returns: the :class:`.SourceInfo` objects describing this source
-
- Raises:
- :class:`.SourceImplError`: if the source class does not implement
this method and does not implement
- :func:`SourceFether.get_source_info()
<buildstream.source.SourceFetcher.get_source_info>`
+ Returns: the :class:`.SourceInfo` objects describing this source, or
``None`` if the
+ SourceFetcher does not implement this method.
Review Comment:
I think you meant Source rather than SourceFetcher.
##########
tests/frontend/source-info-unimplemented/fatal/elements/unimplemented.bst:
##########
@@ -0,0 +1,4 @@
+kind: import
+
+sources:
+- kind: fatal_unimplemented
Review Comment:
Is there a reason to call the plugins "fatal_unimplemented" and
"non_fatal_unimplemented"? AFAICT, they are identical and the difference is in
the project rather than the sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
