This is an automated email from the ASF dual-hosted git repository. akitouni pushed a commit to branch abderrahim/sandbox-remote-no-artifactcache in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 65e4d35dd7abd274fb33773f94fb3ca106ca3d92 Author: Abderrahim Kitouni <[email protected]> AuthorDate: Tue Jul 8 08:21:04 2025 +0100 _sandboxremote.py: stop trying to pull partial artifacts There used to be a time where buildstream could partially download artifacts, which could mean that not all artifact blobs are available locally. This is no longer the case: support for partial artifacts was dropped in favour of the cache storage-service and is only used for buildtrees, which aren't used in this case. Downloading missing blobs from the cache storage-service is handled in `CASCache._send_blobs()` called a few lines below. --- src/buildstream/sandbox/_sandboxremote.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/buildstream/sandbox/_sandboxremote.py b/src/buildstream/sandbox/_sandboxremote.py index 8abaa2b53..c8fc28425 100644 --- a/src/buildstream/sandbox/_sandboxremote.py +++ b/src/buildstream/sandbox/_sandboxremote.py @@ -249,7 +249,6 @@ class SandboxRemote(SandboxREAPI): context = self._get_context() project = self._get_project() cascache = context.get_cascache() - artifactcache = context.artifactcache action_digest = cascache.add_object(buffer=action.SerializeToString()) @@ -269,15 +268,6 @@ class SandboxRemote(SandboxREAPI): except grpc.RpcError as e: raise SandboxError("Failed to determine missing blobs: {}".format(e)) from e - # Check if any blobs are also missing locally (partial artifact) - # and pull them from the artifact cache. - try: - local_missing_blobs = cascache.missing_blobs(missing_blobs) - if local_missing_blobs: - artifactcache.fetch_missing_blobs(project, local_missing_blobs) - except (grpc.RpcError, BstError) as e: - raise SandboxError("Failed to pull missing blobs from artifact cache: {}".format(e)) from e - # Add command and action messages to blob list to push missing_blobs.append(action.command_digest) missing_blobs.append(action_digest)
