kevinschoon commented on code in PR #2035: URL: https://github.com/apache/buildstream/pull/2035#discussion_r2194803119
########## src/buildstream/types.py: ########## @@ -389,6 +389,40 @@ def new_from_node(cls, node: MappingNode) -> "_SourceMirror": return cls(name, aliases) +# Used to indicate the state of a given element +class _ElementState(FastEnum): Review Comment: The only place AFAIK that introduces the concept of "states" is in the `bst show` command as seen here: https://github.com/apache/buildstream/blob/master/src/buildstream/_frontend/widget.py#L363-L381. I think that the `_ElementState` enum could move privately into `inspect.py` though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@buildstream.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org