juergbi commented on code in PR #2031: URL: https://github.com/apache/buildstream/pull/2031#discussion_r2200660210
########## src/buildstream/sandbox/_sandboxbuildboxrun.py: ########## @@ -32,6 +34,27 @@ # BuildBox-based sandbox implementation. # class SandboxBuildBoxRun(SandboxREAPI): + def __init__(self, *args, **kwargs): + super().__init__(*args, **kwargs) + + context = self._get_context() + cascache = context.get_cascache() + + re_specs = context.remote_execution_specs + if re_specs and re_specs.action_spec and not re_specs.exec_spec: Review Comment: When we add action cache support for BuildStream actions, we need to make sure that we're not attempting to cache interactive shells. However, I don't think we need to disable remote execution or action cache access for sandboxed REAPI clients, so I've removed this condition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@buildstream.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
