juergbi commented on PR #2033: URL: https://github.com/apache/buildstream/pull/2033#issuecomment-3062696095
I think the main issue is that failed actions are cached in the action cache in the first place. While there may be circumstances where caching failed actions is useful, I don't think we need this for BuildStream at all (given that we have a higher level caching mechanism where we already support caching failures) and most remote execution servers default to not caching failed actions, mainly because failures may be spurious, e.g., due to a worker running out of RAM. BuildGrid caches failures by default but it can be disabled with `cache-failed-actions: false`. buildbox-casd currently unconditionally caches failures but I think we should change that or at least add an option to disable it. On the BuildStream side, might it be sufficient to skip action cache lookup (direct action cache query as well as indirectly via Execute()) if `context.build_retry_failed` is set? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@buildstream.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
