juergbi commented on code in PR #2036:
URL: https://github.com/apache/buildstream/pull/2036#discussion_r2239260362
##########
src/buildstream/buildelement.py:
##########
@@ -285,10 +305,20 @@ def configure_sandbox(self, sandbox):
command_dir = build_root
sandbox.set_work_directory(command_dir)
- # Setup environment
- sandbox.set_environment(self.get_environment())
-
def stage(self, sandbox):
+ # Setup environment
Review Comment:
Right, it's part of the low diversity metadata. I'll have to check whether
this would allow us to completely skip `configure_sandbox()` for the buildtree
shell.
However, even if that works, there is still one potential issue, which is
that this would not guarantee that the directory tree referenced by the digest
environment variable is available in the local cache, as the artifact doesn't
reference that digest (except via that environment variable but BuildStream
core is not aware of that). Maybe we can add that to the Artifact proto as
well, but this may require additional code and API in the core for use by
`BuildElement`. Or do you have another suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
