juergbi commented on code in PR #2085:
URL: https://github.com/apache/buildstream/pull/2085#discussion_r2486128588
##########
pyproject.toml:
##########
@@ -53,10 +53,11 @@ environment = { BST_BUNDLE_BUILDBOX = "1" }
manylinux-x86_64-image = "manylinux_2_28"
skip = [
- # BuildStream supports Python >= 3.9
+ # BuildStream supports Python >= 3.10
Review Comment:
The best way would be to migrate project metadata to `pyproject.toml`.
However, if I remember correctly, it's not possible to add `[project]` with a
single field such as `requires-python` and leave everything else as is. We'd
have to migrate all the project metadata over from `setup.py`. While that would
be nice, it may be a bit more work and should be a separate PR (I'm not sure
whether we could keep the non-metadata parts of `setup.py` as is).
However, it does seem reasonable to replace part of the `skip` list with
`project-requires-python`. I'll give this a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
