joshua-zivkovic commented on issue #2073:
URL: https://github.com/apache/buildstream/issues/2073#issuecomment-3632498963

   # Overriding incorrect, auto-generated, provenance info
   
   When using source track to generate source provenance info, it might not 
always be correct, for various reasons. In such cases a user should be able to 
override any field to be the correct value.
   
   The problem here is doing such in a user friendly way that is also 
consistent with existing buildstream usage.
   
   ## Separate deifintion for user overrides
   ```yaml
   sources:
       kind: cargo2
       provenance-overrides:
           foo:
               issue-tracker: ###
       ref:
       - kind: registry
         name: foo
         provenance:
             issue-tracker: ~~~
   ```
   
   - Clearly explicit
   - Possibly misleading if you don't read the overrides
   - You also need to go between overrides and generated provenance fields when 
reviewing
   
   ## Specifying overrides with formatting
   ```yaml
   sources:
       kind: cargo2
       ref:
       - kind: registry
         name: foo
         provenance:
             issue-tracker: ! ###
   ```
   
   - Removes multiple definitions making review easier, no need to view 
overrides separately
   - Special formatting might be misleading/not fool proof
   - easier to view in larger files that have a lot of cargo dependencies
   
   ---
   
   A third option that is more outside of the box would be a sort of 
interactive `source track` for provenance in cases like this. If the generated 
field differs from the current value, it creates a conflict that must be 
resolved (similar to a git rebase).
   
   This removes the need for any duplication, special formatting/syntax, but 
obviously at the cost of a more expensive implementation and a new concept for 
buildstream.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to