joshua-zivkovic commented on code in PR #2098:
URL: https://github.com/apache/buildstream/pull/2098#discussion_r2712871608
##########
src/buildstream/source.py:
##########
@@ -1386,15 +1387,23 @@ def create_source_info(
choice depicting the type of version.
version: A string which represents a unique version of this source
input
version_guess: An optional string representing the guessed human
readable version
+ provenance_node: The optional YAML node with source provenance
attributes,
+ defaults to the provenance specified at the top
level of the source.
Review Comment:
Ah, that is something that has been completely overlooked yes. I think a
"multi-source" plugin should simply have a flag that it sets when used to tell
the core to not use top-level source provenance data and actually disallow it
(preventing the top level being silently ignored)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
