joshua-zivkovic commented on code in PR #2099:
URL: https://github.com/apache/buildstream/pull/2099#discussion_r2753215415


##########
src/buildstream/source.py:
##########
@@ -396,6 +402,8 @@
 
     # pylint: enable=cyclic-import
 
+SourceProvenance = MappingNode

Review Comment:
   I wanted to try and be clearer that something was for `SourceProvenance` 
rather than, somewhat confusingly, just any `MappingNode`. This obviously isn't 
entirely fool proof though and since there's no other cases of this I suppose 
it's sensible to just remove it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to