juergbi commented on code in PR #98:
URL:
https://github.com/apache/buildstream-plugins/pull/98#discussion_r2804807933
##########
src/buildstream_plugins/sources/cargo.py:
##########
@@ -513,10 +549,17 @@ def _parse_crates(self, refs):
crate.get_str("name"),
crate.get_str("version"),
sha=crate.get_str("sha", None),
+ provenance=crate.get_mapping("provenance", None),
)
for crate in refs
]
+ def _drop_provenance_field(self, refs):
+ for crate in refs.copy():
Review Comment:
`copy()` creates a shallow copy of the `refs` list. I would assume the
intention was rather to copy each `crate` dict such that the deletions don't
affect the input dicts. Or can you explain how this works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
