kotborealis opened a new pull request, #2125: URL: https://github.com/apache/buildstream/pull/2125
Fixes a bug where `workspace reset` did not work for junctions. For example, we have a project with struct like this: ``` nested.bst:hello.bst ``` So the root project has one element `nested.bst`, which is a junction to another project, and the junction has one element `hello.bst`. If we try to open this element as workspace, it works: ``` bst workspace open nested.bst:hello.bst ``` If we try to close this workspace, it works: ``` bst workspace close nested.bst:hello.bst ``` However, if we try `bst workspace reset` command on it, it fails with error `Workspace does not exist`. The error is that `workspace_reset` method called `workspace_exists` with `element.name`, which was resolved to just `hello.bst`. In comparsion, a few lines down, it uses `get_workspace` with `element._get_full_name()`, which is `nested.bst:hello.bst`. This patch updates `workspace_reset` function to check existence using element full name to support junctions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
