abderrahim commented on code in PR #2137:
URL: https://github.com/apache/buildstream/pull/2137#discussion_r3610503618


##########
tests/frontend/workspace.py:
##########
@@ -634,6 +634,49 @@ def test_reset_all(cli, tmpdir, datafiles):
     assert not os.path.exists(os.path.join(workspace_beta, "etc", "pony.conf"))
 
 
[email protected](DATA_DIR)
+def test_reset_all_with_elements_error(cli, tmpdir, datafiles):

Review Comment:
   The two tests you added here are essentially the same, please merge them 
into one and use `@pytest.mark.parametrize` to pass the element name (which 
would be either the actual element or the bogus --soft option)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to