juergbi commented on issue #2156: URL: https://github.com/apache/buildstream/issues/2156#issuecomment-5140737683
Too aggressive keepalive can cause problems depending on server and possible proxy. I think a default of 5 min (which is also the server side default for `GRPC_ARG_HTTP2_MIN_RECV_PING_INTERVAL_WITHOUT_DATA_MS`) may be reasonable for BuildStream, though, especially considering that this will only apply to active sessions, not some persistent background daemon. It may make sense to keep keepalive disabled by default in buildbox-casd upstream, though, as buildbox-casd may be used as a persistent background daemon where regular pings may not be desired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
