kotborealis opened a new pull request, #2166: URL: https://github.com/apache/buildstream/pull/2166
The soft reset path cleared `workspace.last_build` only in memory. Since `workspace_reset()` returned without `Workspaces.save_config()`, the old hash remained in `.bst2/workspaces.yml` and was loaded by the next BuildStream invocation. That retained the previous buildtree and could skip configure-commands. This regressed in 1eedab4fd, when the final save after the reset loop was removed as hard reset moved to `workspace_close()`/`workspace_open()`; those methods save the config themselves, but the soft path does not. The later `last_successful` -> `last_build` rename preserved the omission. Save the config once after all soft-reset targets are processed and cover the on-disk state before and after a new CLI invocation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
