c1assik opened a new pull request, #2174:
URL: https://github.com/apache/buildstream/pull/2174
`artifact_log()` and `artifact_list_contents()` were keying their result
dicts by `obj.name`, which is just the bare, project-relative element name. For
elements loaded across a junction, this drops the owning junction prefix, so
e.g. `bst artifact list-contents element.bst nested.bst:element.bst` would only
show one entry, since both targets resolved to the same key.
Use `obj._get_full_name()` instead, which includes the junction prefix,
falling back to the artifact ref for `ArtifactElement` targets (i.e. when an
artifact is referred to by its ref rather than its element name) as before.
Also drops a dead `obj.name = {ref: "No artifact cached"}` assignment in
`artifact_list_contents()` that was immediately followed by `continue` and
never used.
Add tests covering `artifact log` and `artifact list-contents` with a
cross-junction element alongside a same-named top-level element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
