nathanwilliams-ct commented on code in PR #2175:
URL: https://github.com/apache/buildstream/pull/2175#discussion_r3796604725
##########
src/buildstream/_frontend/cli.py:
##########
@@ -420,7 +420,7 @@ def help_command(ctx, command):
@click.option(
"--min-version",
type=click.STRING,
- default="2.7",
Review Comment:
In the test, is it worth adding a memo, along the lines of:
`assert project_conf.get_str("min-version") == get_default_min_version(),
'project min version does not equal default min version. If this is failing and
repository was recently tagged, a version update PR is required for this test
to pass again.'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
