juergbi commented on code in PR #2147:
URL: https://github.com/apache/buildstream/pull/2147#discussion_r3988789301
##########
src/buildstream/_loader/loader.py:
##########
@@ -255,6 +255,19 @@ def foreach_parent(parent):
# Private Methods #
###########################################
+ # _set_fullpath_overrides()
Review Comment:
This shouldn't be a private method as it's used by `Stream`. `Loader` is not
part of the public (plugin) API, so 'public' methods in `Loader` will still
only be part of the internal API.
Also, `_set_fullpath_overrides()` sounds to me like it sets the whole dict
as it's plural. I might call it `add_fullpath_override()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
