Thanatos9404 commented on code in PR #2208: URL: https://github.com/apache/buildstream/pull/2208#discussion_r4323168337
########## src/buildstream/_frontend/widget.py: ########## Review Comment: That one is deliberate. On master a scheduler FAIL message always ends with an empty line (two in verbose mode with `error-lines: 0`), and the Failure Summary relies on it: `print_summary` hands the rendered messages to `_format_values`, which appends them back to back, so without it the next `element.bst:` entry would start right after the message. Keeping `extra_nl` outside the branches leaves exactly one empty line in that case, which `test_error_lines_zero` checks. Happy to move it in if you'd rather drop the blank line there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
