juergbi commented on PR #2215: URL: https://github.com/apache/buildstream/pull/2215#issuecomment-6492085085
Thank you for your contribution. However, from a brief look it doesn't seem this has been tested in any real scenario as it doesn't capture mode bits of build outputs (and there are also no tests in this PR). Furthermore, this would require configurability for security and backwards compatibility reasons. This is at least partially discussed in #38. I.e., as my impression is that this was never tested and it's far from a proper solution to #38, I'm closing this. If you want to seriously work on fixing #38, the solution should address the aspects mentioned in the issue and tests should demonstrate that it actually works. Possibly with a design proposal before a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
