svn commit: r1591815 - in /bval/branches/bval-11/bval-jsr/src: main/java/org/apache/bval/jsr/JsrMetaBeanFactory.java main/java/org/apache/bval/jsr/util/ClassHelper.java test/java/org/apache/bval/jsr/ValidationTest.java

[rmannibucau]

Author: rmannibucau
Date: Fri May  2 05:31:19 2014
New Revision: 1591815

URL: http://svn.apache.org/r1591815
Log:
BVAL-128 avoid Cloneable as Serializable. Thanks Michael Blyakher for the patch

Modified:
    
bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/JsrMetaBeanFactory.java
    
bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/util/ClassHelper.java
    
bval/branches/bval-11/bval-jsr/src/test/java/org/apache/bval/jsr/ValidationTest.java

Modified: 
bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/JsrMetaBeanFactory.java
URL: 
http://svn.apache.org/viewvc/bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/JsrMetaBeanFactory.java?rev=1591815&r1=1591814&r2=1591815&view=diff
==============================================================================
--- 
bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/JsrMetaBeanFactory.java
 (original)
+++ 
bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/JsrMetaBeanFactory.java
 Fri May  2 05:31:19 2014
@@ -97,10 +97,6 @@ public class JsrMetaBeanFactory implemen
             // time of processing
             for (int i = classSequence.size() - 1; i >= 0; i--) {
                 Class<?> eachClass = classSequence.get(i);
-                if (eachClass == Serializable.class || eachClass == 
Cloneable.class) {
-                    continue;
-                }
-
                 processClass(eachClass, metabean);
                 processGroupSequence(eachClass, metabean, "{GroupSequence:" + 
eachClass.getCanonicalName() + "}");
             }

Modified: 
bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/util/ClassHelper.java
URL: 
http://svn.apache.org/viewvc/bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/util/ClassHelper.java?rev=1591815&r1=1591814&r2=1591815&view=diff
==============================================================================
--- 
bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/util/ClassHelper.java
 (original)
+++ 
bval/branches/bval-11/bval-jsr/src/main/java/org/apache/bval/jsr/util/ClassHelper.java
 Fri May  2 05:31:19 2014
@@ -44,7 +44,7 @@ public class ClassHelper {
      * @param clazz
      */
     static public List<Class<?>> fillFullClassHierarchyAsList(List<Class<?>> 
allClasses, Class<?> clazz) {
-        if (clazz == null || clazz == Object.class || clazz == 
Serializable.class) {
+        if (clazz == null || clazz == Object.class || clazz == 
Serializable.class || clazz == Cloneable.class) {
             return allClasses;
         }
         if (allClasses.contains(clazz)) {

Modified: 
bval/branches/bval-11/bval-jsr/src/test/java/org/apache/bval/jsr/ValidationTest.java
URL: 
http://svn.apache.org/viewvc/bval/branches/bval-11/bval-jsr/src/test/java/org/apache/bval/jsr/ValidationTest.java?rev=1591815&r1=1591814&r2=1591815&view=diff
==============================================================================
--- 
bval/branches/bval-11/bval-jsr/src/test/java/org/apache/bval/jsr/ValidationTest.java
 (original)
+++ 
bval/branches/bval-11/bval-jsr/src/test/java/org/apache/bval/jsr/ValidationTest.java
 Fri May  2 05:31:19 2014
@@ -716,4 +716,13 @@ public class ValidationTest extends Test
         Assert.assertFalse(beanDescriptor.isBeanConstrained());
         Assert.assertNull(beanDescriptor.getConstraintsForProperty("[0]"));
     }
+    
+    public void testValidateClassImplementingCloneable() {
+       Set<ConstraintViolation<TestCloneableClass>> errors = 
validator.validate(new TestCloneableClass());
+       Assert.assertTrue(errors.isEmpty());
+    }
+    
+    private static class TestCloneableClass implements Cloneable {
+       
+    }
 }